Skip to content

enhance(pdf): pdf password support #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiensonqin merged 2 commits into from
Aug 21, 2023
Merged

enhance(pdf): pdf password support #10034

tiensonqin merged 2 commits into from
Aug 21, 2023

Conversation

@andelf
Copy link
Collaborator

@andelf andelf commented Aug 16, 2023

Close #10033

Help Wanted:

  • How to set a callback for the modal's close button? (in order to cancel opening pdf)

@andelf andelf requested a review from xyhp915 August 16, 2023 17:30
@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Aug 16, 2023
@andelf
Copy link
Collaborator Author

andelf commented Aug 16, 2023 •
edited
Loading

To test:

sample-protected.pdf
A demo PDF with "123456" as the password.

And,

Password protect a PDF online for free | Adobe Acrobat

@andelf andelf changed the title enhance(pdf): pdf password input modal enhance(pdf): pdf password support Aug 17, 2023
xyhp915
xyhp915 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@xyhp915 xyhp915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiensonqin tiensonqin force-pushed the enhance/pdf-password-support branch from 6d9a325 to e8f3e45 Compare August 21, 2023 15:48
@tiensonqin tiensonqin merged commit 90bbd03 into master Aug 21, 2023
@tiensonqin tiensonqin deleted the enhance/pdf-password-support branch August 21, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xyhp915 xyhp915 xyhp915 approved these changes

@logseq-cldwalker logseq-cldwalker Awaiting requested review from logseq-cldwalker

Assignees

No one assigned

Labels

:type/enhancement Enhancement to product. Does not affect the overall basic use.

Projects

None yet

Milestone

No milestone

4 participants

@andelf @xyhp915 @tiensonqin