Stretch systemd timer over one hour#574
Merged
cgzones merged 1 commit intologrotate:mainfrom Mar 15, 2024
Merged
Conversation
The initial introduction of the systemd timer in commit 05228c2 ("Add logrotate service and timer for systemd") included the directive `AccuracySec=12h`. AccuracySec= is not a load distribution option but a power saving one, see systemd-timer(5). In commit 3f3991e ("Timer unit: change trigger fuzz from 12h to 1h") the value was reduced to 1h, while the discussion in logrotate#230 also mentioned load distribution. Use RandomizedDelaySec= instead of AccuracySec= to actually spread the start time of the service, and ignore potential system wakeups below the rate of the default of AccuracySec= of one minute. Fixes: logrotate#567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial introduction of the systemd timer in commit 05228c2 ("Add logrotate service and timer for systemd") included the directive
AccuracySec=12h. AccuracySec= is not a load distribution option but a power saving one, see systemd-timer(5). In commit 3f3991e ("Timer unit: change trigger fuzz from 12h to 1h") the value was reduced to 1h, while the discussion in #230 also mentioned load distribution.Use RandomizedDelaySec= instead of AccuracySec= to actually spread the start time of the service, and ignore potential system wakeups below the rate of the default of AccuracySec= of one minute.
Fixes: #567