Closed
Conversation
cgzones
reviewed
Dec 11, 2023
Member
cgzones
left a comment
There was a problem hiding this comment.
Besides the inline nits, LGTM.
| the \fBolddir\fR directory will belong to (see the section \fBUSER AND GROUP | ||
| \fR for details). This option can be disabled using | ||
| the \fBnocreateolddir\fR option. | ||
| the \fBnocreateolddir\fR option. If \fImode\fR is not specified, \fB0755\fR is assumed. |
Member
There was a problem hiding this comment.
Generally the sentence This option can be disabled using the \fBfoo\fR option. comes last in the other blocks.
| rv = readModeUidGid(configFile, lineNum, key, "createolddir", | ||
| &newlog->olddirMode, &newlog->olddirUid, | ||
| &newlog->olddirGid); | ||
| if (newlog->olddirMode == NO_MODE) { |
Member
There was a problem hiding this comment.
Personally I would order this adjustment after the error check.
| &newlog->olddirGid); | ||
| if (newlog->olddirMode == NO_MODE) { | ||
| newlog->olddirMode = 0755; | ||
| } |
Member
There was a problem hiding this comment.
Please correct the indentation.
Member
|
Applied via 47f79e7 with minor formatting adjustments. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File mode is optional for
createandolddircreate, therefore old directory will be created with mode037777777777if not specified.