Avoid writing state to non regular files#529
Merged
cgzones merged 2 commits intologrotate:masterfrom Jul 13, 2023
Merged
Conversation
The entry '.' should always be a directory; be pedantic about it and open it with the flag O_DIRECTORY.
Prevent the usage of non-regular files as state file. The state is not actually written to the file of arbitrary type but a regular temporary one, which gets renamed at the end. For example an erroneous usage of /dev/zero (instead of /dev/null) leads to a replacement of the character device file /dev/zero by a regular one.
kdudka
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the usage of non-regular files as state file. The state is not actually written to the file of arbitrary type but a regular temporary one, which gets renamed at the end.
For example an erroneous usage of
/dev/zero(instead of/dev/null) leads to a replacement of the character device file/dev/zeroby a regular one.