Restore old time_t difference calculations #516
Merged
cgzones merged 4 commits intologrotate:masterfrom Jun 30, 2023
Merged
Conversation
kdudka
approved these changes
May 9, 2023
With the introduction of difftime(3) in commit 4eb3add ("Use difftime to compare time_t") to support platform with an unsigned time_t several arithmetic operations and comparisons turned from integer to floating point ones. This can lead to different results since integer divisions round down to the next integer while floating point divisions do not. Cast the result of difftime(3) to intmax_t to revert back to integer operations. Fixes: 4eb3add ("Use difftime to compare time_t") Fixes: logrotate#514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of difftime(3) in commit 4eb3add ("Use difftime
to compare time_t") to support platform with an unsigned time_t several
arithmetic operations and comparisons turned from integer to floating
point ones. This can lead to different results since integer divisions
round down to the next integer while floating point divisions do not.
Cast the result of difftime(3) to intmax_t to revert back to integer
operations.
Fixes: 4eb3add ("Use difftime to compare time_t")
Fixes: #514
Supersedes: #515
Additionally contains some test cases and minor changes.