do not rotate old logs on prerotate failure#506
Merged
cgzones merged 1 commit intologrotate:masterfrom May 5, 2023
Merged
Conversation
kdudka
approved these changes
Apr 24, 2023
Member
kdudka
left a comment
There was a problem hiding this comment.
Should we also describe the behavior in the man page more precisely?
Ensures old logs are preserved and not rotated out for logs with a failing prerotate script. Alternative to logrotate#502
Member
Author
Improved the man page a bit; or did you mean a complete action order list (firstaction, prerotate, rotating old logs, rotating log file, ..., lastaction)? |
Member
|
I think the updated wording is fine. I admit I had to read it twice but hopefully understood in the end :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures old logs are preserved and not rotated out for logs with a failing prerotate script.
Alternative to #502