Do not lock state file /dev/null#433
Merged
cgzones merged 1 commit intologrotate:masterfrom Jan 25, 2022
Merged
Conversation
logrotate#395 introduced /dev/null as supported state file path for cases when no state file is desired. lockState() tries to open and lock the state file to avoid issues with concurrent instances, see logrotate#295. Locking the character file /dev/null might either be not supported, e.g. on Debian GNU/Hurd (hurd-i386), nor not allowed, e.g. by SELinux.
kdudka
approved these changes
Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#395 introduced
/dev/nullas supported state file path for cases when no state file is desired.lockState()tries to open and lock the state file to avoid issues with concurrent instances, see #295.Locking the character file
/dev/nullmight either be not supported, e.g. on Debian GNU/Hurd (hurd-i386), nor not allowed, e.g. by SELinux.