Avoid confusing error message in debug mode#426
Merged
cgzones merged 1 commit intologrotate:masterfrom Nov 2, 2021
Merged
Conversation
kdudka
approved these changes
Oct 14, 2021
Member
kdudka
left a comment
There was a problem hiding this comment.
Looks good, one coding style suggestion inline.
In debug mode the state file is not created if not already existent in
lockState(). Do not print the message
error: error opening state file /var/lib/logrotate.status: No such file or directory
while trying to read the state file, since in debug mode this is not an
error.
Related: logrotate#425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debug mode the state file is not created if not already existent in
lockState(). Do not print the message
while trying to read the state file, since in debug mode this is not an
error.
Related: #425