Fix full_write on incomplete write#415
Merged
cgzones merged 1 commit intologrotate:masterfrom Aug 24, 2021
Merged
Conversation
Member
|
The actual fix looks good. I am not sure about the added Another preexisting issue with the code is that it should not check the value of |
Currently on an incomplete write(2) the subsequent write(2) will again
use the same starting position in the given buffer, which was already
successfully written, leading to data corruption.
Found by clang-13
logrotate.c:1140:17: warning: variable 'ptr' set but not used [-Wunused-but-set-variable]
const char *ptr = (const char *) buf;
^
Also check for EINTR only on write(2) failure.
Also use `unsigned char *` to signal handling bytes, not a string.
Fixes: f1dc0d9 ("Allow rotation of sparse files with copytruncate")
Member
Author
True, I updated the patch. |
kdudka
approved these changes
Aug 10, 2021
Member
kdudka
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on an incomplete write(3) the subsequent write(3) will again
use the same starting position in the given buffer, which was already
successfully written, leading to data corruption.
Found by clang-13
Fixes: f1dc0d9 ("Allow rotation of sparse files with copytruncate")