Use O_CREAT in createOutputFile#398
Merged
cgzones merged 1 commit intologrotate:masterfrom Jun 14, 2021
Merged
Conversation
As the name suggests `createOutputFile()` does create a new file by using the flag O_EXCL and all its callers using the flag O_CREAT. Use O_CREAT inside of `createOutputFile()` instead of specifying it by every caller.
kdudka
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the name suggests
createOutputFile()does create a new file byusing the flag O_EXCL and all its callers using the flag O_CREAT.
Use O_CREAT inside of
createOutputFile()instead of specifying it byevery caller.