lock state file to prevent parallel execution#297
Closed
cgzones wants to merge 1 commit intologrotate:masterfrom
Closed
lock state file to prevent parallel execution#297cgzones wants to merge 1 commit intologrotate:masterfrom
cgzones wants to merge 1 commit intologrotate:masterfrom
Conversation
Member
|
Thank you for working on this! I will review it after the planned release of logrotate. My initial feeling is that this will need to be optional to cover the environments where the locking mechanism does not work reliably. There is some risk that the change will trigger problems even without parallel invocation. |
kdudka
requested changes
Mar 13, 2020
kdudka
reviewed
May 28, 2020
4f71e98 to
5c5813c
Compare
kdudka
requested changes
Jun 1, 2020
Running multiple instances of logrotate on the same set of log-files might have undesirable effects. Add command line option --skip-state-lock to skip locking the state file, for example if locking is unsupported or prohibited.
Member
|
Merging now. Thank you for being patient while contributing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #295