Ignore .bob when publishing#975
Merged
nomiddlename merged 1 commit intolog4js-node:masterfrom Jan 29, 2020
Merged
Conversation
We noticed that .bob was in our production container ``` du -k node_modules/* | awk '$1 > 2000' | sort -nr 2648 node_modules/log4js/.bob 2632 node_modules/log4js/.bob/complexity 2624 node_modules/log4js/.bob/complexity/plato ``` Since .bob is in the .gitignore and only referenced in the tests https://github.com/log4js-node/log4js-node/blob/5545f2a932e012177e553bfda90d8b3fba80b332/test/tap/LoggingEvent-test.js#L19 we figured you might want to add it to the .npmignore
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 25 25
Lines 1012 1012
=======================================
Hits 998 998
Misses 14 14Continue to review full report at Codecov.
|
Collaborator
|
Wow. Thanks for picking that up - bob was a build tool we used back in the early days of this project (maybe 8 years ago). |
Collaborator
|
Published to npm in log4js@6.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that .bob was in our production container
Since .bob is in the .gitignore and only referenced in the tests
log4js-node/test/tap/LoggingEvent-test.js
Line 19 in 5545f2a