[fix]change wrong property name, from 'numBackups' to 'backups'#807
Merged
nomiddlename merged 1 commit intolog4js-node:masterfrom Nov 14, 2018
jiro4989:hotfix/fix_example_code
Merged
[fix]change wrong property name, from 'numBackups' to 'backups'#807nomiddlename merged 1 commit intolog4js-node:masterfrom jiro4989:hotfix/fix_example_code
nomiddlename merged 1 commit intolog4js-node:masterfrom
jiro4989:hotfix/fix_example_code
Conversation
Codecov Report
@@ Coverage Diff @@
## master #807 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 24 24
Lines 914 914
=======================================
Hits 891 891
Misses 23 23Continue to review full report at Codecov.
|
Collaborator
|
Thanks - well spotted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Property name is wrong of example code.
I think that property name is backups, not numBackups when config.type is 'file'.
log4js-node/lib/appenders/file.js
Line 92 in 86333dc
document
https://log4js-node.github.io/log4js-node/file.html
thx.