ci: add dist sync validation workflow#6137
Merged
UlisesGascon merged 2 commits intolodash:mainfrom Mar 25, 2026
Merged
Conversation
falsyvalues
approved these changes
Mar 25, 2026
falsyvalues
reviewed
Mar 25, 2026
|
|
||
| - name: Check dist files are in sync | ||
| run: | | ||
| if git diff --exit-code dist/; then |
Member
There was a problem hiding this comment.
Simplicity of that is awesome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dist/files are committed to the repo but there's no CI check ensuring they stay in sync with source. This means a release could ship stale dist files if someone forgets to rebuild before merging. This workflow catches that drift automatically.Usage
As expected, this fails when we are out of sync (ref):
But works fine when they are (ref), like on this sync commit (ref)