Merged
Conversation
bbfc271 to
415b170
Compare
cyberw
reviewed
Nov 17, 2025
locust/opentelemetry.py
Outdated
| from opentelemetry import metrics, trace | ||
| from opentelemetry.sdk.resources import Resource | ||
| except ImportError: | ||
| logger.debug("OpenTelemetry SDK is not installed, opentelemetry not enabled") |
Collaborator
There was a problem hiding this comment.
put this first in the function. if sdk isnt even installed there's no reason to talk about no exporters being configured etc
Collaborator
There was a problem hiding this comment.
Maybe mention doing pip install locust[otel] to fix it
cyberw
reviewed
Nov 17, 2025
locust/opentelemetry.py
Outdated
|
|
||
| _setup_auto_instrumentation() | ||
|
|
||
| logger.info("OpenTelemetry configured!") |
cyberw
reviewed
Nov 17, 2025
| dns = ["dnspython>=2.8.0"] | ||
| otel = [ | ||
| "opentelemetry-sdk>=1.38.0", | ||
| "opentelemetry-exporter-otlp-proto-grpc>=1.38.0", |
Collaborator
There was a problem hiding this comment.
should we also install http? if we do, we can also remove the slightly complicated handling of ImportError.
In general, we dont need to support an incomplete installation (missing urllib3 instrumentation or whatnot). Just crashing is cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also configures auto instrumentation for
HttpUserby instrumentingrequestspackage