fix: MQTT client_id and protocol not passed down to Client#3252
Merged
cyberw merged 2 commits intolocustio:masterfrom Nov 1, 2025
Merged
fix: MQTT client_id and protocol not passed down to Client#3252cyberw merged 2 commits intolocustio:masterfrom
cyberw merged 2 commits intolocustio:masterfrom
Conversation
Contributor
Author
|
should I add a test to ensure that the protocol is passed on correctly? |
Collaborator
|
No need for a test, but probably nice to add an example for how to use it! |
Collaborator
|
I just realized that you were only correcting a mistake in moving it, in which case no need for anything more :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating the MqttClient from Locust Plugins I accidentally modified the call to the parent constructor.
SvenskaSpel/locust-plugins@f1845b9#diff-94fac3dc568e54a6e6f7dc07955bfe16912cea237d2dfcc98f54d97d9d556071L115