Skip to content

Fix Util for Writing to bags#11

Merged
DLu merged 1 commit intolocus-melodic-develfrom
feature/bag_encryption
Apr 5, 2019
Merged

Fix Util for Writing to bags#11
DLu merged 1 commit intolocus-melodic-develfrom
feature/bag_encryption

Conversation

@DLu
Copy link
Copy Markdown

@DLu DLu commented Apr 3, 2019

Cherry picks ros#1499

Otherwise, writing to a bag (from within a plugin) may result in

terminate called after throwing an instance of 'pluginlib::CreateClassException'
  what():  MultiLibraryClassLoader: Could not create object of class type rosbag::NoEncryptor as no factory exists for it. Make sure that the library exists and was explicitly loaded through MultiLibraryClassLoader::loadLibrary()

@jalkino @DLu
fix ros#1474 move bag encryption plugins into separate library (ros#1499
5cb22a8 
)

* fix ros#1474 move bag encryption plugins into separate library

This setup is required by the class_loader, which is part of the pluginlib, see  http://wiki.ros.org/class_loader#Caution_of_Linking_Directly_Against_Plugin_Libraries

* fix unit tests of aes_encryptor
@DLu DLu requested a review from paulbovbel April 3, 2019 22:50
@DLu DLu requested a review from garyservin April 5, 2019 13:31
@DLu DLu merged commit b3e5962 into locus-melodic-devel Apr 5, 2019
@DLu DLu deleted the feature/bag_encryption branch April 5, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garyservin garyservin garyservin approved these changes

@paulbovbel paulbovbel paulbovbel approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DLu @garyservin @paulbovbel @jalkino