Skip to content

backend: hand revocation entries to silo, make sure all metadata fields are set#707

Merged
fengelniederhammer merged 2 commits intomainfrom
704-backend-hand-null-entries-to-silo
Jan 24, 2024
Merged

backend: hand revocation entries to silo, make sure all metadata fields are set#707
fengelniederhammer merged 2 commits intomainfrom
704-backend-hand-null-entries-to-silo

Conversation

@fengelniederhammer
Copy link
Copy Markdown
Contributor

@fengelniederhammer fengelniederhammer commented Dec 22, 2023

resolves #704
resolves #429

This PR serves as data source for the implementation is SILO, merge needs to wait until GenSpectrum/LAPIS-SILO#220 is done.

@fengelniederhammer fengelniederhammer requested review from a user and JonasKellerer December 22, 2023 14:42
@fengelniederhammer fengelniederhammer force-pushed the 704-backend-hand-null-entries-to-silo branch 2 times, most recently from b8e4dbb to 97d32c0 Compare December 22, 2023 15:02
@fengelniederhammer fengelniederhammer force-pushed the 704-backend-hand-null-entries-to-silo branch from 97d32c0 to 3d3b16b Compare January 23, 2024 16:24
@fengelniederhammer fengelniederhammer requested a review from a user January 23, 2024 16:29
@fengelniederhammer
Copy link
Copy Markdown
Contributor Author

SILO is prepared, so this could be merged now.

@fengelniederhammer fengelniederhammer force-pushed the 704-backend-hand-null-entries-to-silo branch from 3d3b16b to f61c9fc Compare January 23, 2024 16:35
@fengelniederhammer fengelniederhammer force-pushed the 704-backend-hand-null-entries-to-silo branch from f61c9fc to 1f4df1c Compare January 24, 2024 08:09
Copy link
Copy Markdown
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengelniederhammer fengelniederhammer force-pushed the 704-backend-hand-null-entries-to-silo branch from 1f4df1c to 267cbef Compare January 24, 2024 09:10
@fengelniederhammer fengelniederhammer merged commit 4e7c662 into main Jan 24, 2024
@fengelniederhammer fengelniederhammer deleted the 704-backend-hand-null-entries-to-silo branch January 24, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend: Hand null entries to SILO Hand revocation versions to SILO

2 participants