Skip to content

374 review page display all sequences and insertions#375

Merged
5 commits merged into
mainfrom
374-review-page-display-all-sequences-and-insertions
Oct 18, 2023
Merged

374 review page display all sequences and insertions#375
5 commits merged into
mainfrom
374-review-page-display-all-sequences-and-insertions

Conversation

@fengelniederhammer

Copy link
Copy Markdown
Contributor

resolves #374

@fengelniederhammer fengelniederhammer requested review from a user and JonasKellerer October 17, 2023 15:45
@netlify

netlify Bot commented Oct 17, 2023

Copy link
Copy Markdown

Deploy Preview for pathoplexus ready!

Name Link
🔨 Latest commit 6943e36
🔍 Latest deploy log https://app.netlify.com/sites/pathoplexus/deploys/652fcba7734fb50008ccf10a
😎 Deploy Preview https://deploy-preview-375--pathoplexus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just started

Comment thread website/src/components/Review/ReviewPage.tsx Outdated
@fengelniederhammer fengelniederhammer force-pushed the 374-review-page-display-all-sequences-and-insertions branch from de10ca7 to d4913b2 Compare October 18, 2023 06:33
@JonasKellerer

Copy link
Copy Markdown
Contributor

When I run it locally through npm run dev I dont get an error. Using npm run start-server I get an error:
`
08:53:46 [build] Complete!
Warning: React.jsx: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.
at ErrorAndWarningIcons (file:///home/kellerer/Dokumente/covSpectrum/pathoplexus/website/dist/server/chunks/pages/_version__61a77981.mjs:74:33)
at td
at tr
at EditableDataRow (file:///home/kellerer/Dokumente/covSpectrum/pathoplexus/website/dist/server/chunks/pages/_version__61a77981.mjs:63:28)
at EditableOriginalData (file:///home/kellerer/Dokumente/covSpectrum/pathoplexus/website/dist/server/chunks/pages/_version__61a77981.mjs:3547:33)
at tbody
at table
at ReviewPage (file:///home/kellerer/Dokumente/covSpectrum/pathoplexus/website/dist/server/chunks/pages/_version__61a77981.mjs:3442:23)
node:internal/process/promises:288
triggerUncaughtException(err, true /* fromPromise */);
^

Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.
at renderElement (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6109:9)
at renderNodeDestructiveImpl (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6170:11)
at renderNodeDestructive (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6142:14)
at renderNode (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6325:12)
at renderHostElement (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:5708:3)
at renderElement (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6018:5)
at renderNodeDestructiveImpl (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6170:11)
at renderNodeDestructive (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6142:14)
at renderNode (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6325:12)
at renderChildrenArray (/home/kellerer/Dokumente/covSpectrum/pathoplexus/website/node_modules/react-dom/cjs/react-dom-server.node.development.js:6277:7)

Node.js v18.17.1

`

@ghost

ghost commented Oct 18, 2023

Copy link
Copy Markdown

I have the same issue.

I take a look what is happening there

@ghost

ghost commented Oct 18, 2023

Copy link
Copy Markdown

The mui icons are the issue. A workaround would be to use NoSsr from mui.

See here

thanks to @theosanderson who brought that issue up in the last PR

@JonasKellerer

Copy link
Copy Markdown
Contributor

Only a short UI remark, but noting to worry about: I would have expected to find the "Submit Review" button on the bottom right.

Comment thread website/src/components/Review/ReviewPage.tsx Outdated
@ghost ghost force-pushed the 374-review-page-display-all-sequences-and-insertions branch from cbd3927 to 6943e36 Compare October 18, 2023 12:12

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread website/src/components/Review/DataRow.tsx Outdated
@ghost ghost merged commit d8d903f into main Oct 18, 2023
@ghost ghost deleted the 374-review-page-display-all-sequences-and-insertions branch October 18, 2023 12:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review page: display all sequences and insertions

2 participants