feat(website): add review page#332
Conversation
✅ Deploy Preview for pathoplexus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
28ab812 to
496d876
Compare
8ca4d50 to
dd8b09a
Compare
1db3867 to
0153a50
Compare
Are you using MUI? MUI doesn't work properly with Astro's hydration (so I think that we should avoid it whenever there is a decent alternative.) |
|
only mui icons... |
|
Sounds like that's it? withastro/astro#6512 |
|
(There's a possible workaround there if one is wedded to these icons - it also may apply to MUI more generally. I've also used react-icons a lot.) |
|
download button will be implemented here #358 |
So, as much changed since the initial commit, now client:load works as expected (even with mui icons). Still a bit curious, what the issue was. |
187713b to
e8f161a
Compare
|
So, this load vs. only issue occured again and now I know the reason: When using map in react each element should have a unique key. Otherwise react will render everthing (in that map) new when a single entry changed. Not fine, but works. Now our hypothesis: |
a815d8c to
cea97c9
Compare
cea97c9 to
db64232
Compare
2af382e to
0d58413
Compare
fengelniederhammer
left a comment
There was a problem hiding this comment.
Some nitpicks, some smaller issues, overall it looks good.
b6517b0 to
8a2fb8d
Compare
fengelniederhammer
left a comment
There was a problem hiding this comment.
Let's do the remaining part in a follow up ticket.
* refactor: prototype for abstracted backend call with proper error handling
8a2fb8d to
d9950b5
Compare
When using map in react each element should have a unique key. Otherwise react will render everything (in that map) new when a single entry changed. Not fine, but works.
Hypothesis:
But when astro needs to hydrate this components, it cannot associate the correct props and the whole thing goes down.