Skip to content

ws: theme refinements#4265

Merged
tvanderstad merged 2 commits intomasterfrom
md-polish
Mar 16, 2026
Merged

ws: theme refinements#4265
tvanderstad merged 2 commits intomasterfrom
md-polish

Conversation

@tvanderstad
Copy link
Copy Markdown
Contributor

Non-functional changes:

  • factors uses of lerp_gamma() for neutrals into pallete_v2.rs
  • removes editor theme; editor now uses the ws theme directly
  • editor code block syntax highlighting now respects the ws theme

Functional changes:

  • foreground green, yellow, and cyan: darkened for light mode
  • egui sync button: blue -> grey
  • egui suggested docs icon from blue -> magenta
  • md cursor/selection, inline code, active fold buttons in dark mode: green -> blue
  • md inline code: re-introduces borders
  • md inline code and table header rows: lightens background in light mode
  • md code blocks: colors updated to match theme

Dark Mode
Before:
Screenshot 2026-03-16 at 5 26 08 PM

After:
Screenshot 2026-03-16 at 5 26 45 PM

Light Mode
Before:
Screenshot 2026-03-16 at 5 25 57 PM

After:
Screenshot 2026-03-16 at 5 26 56 PM

@tvanderstad tvanderstad merged commit c8e316c into master Mar 16, 2026
1 check passed
@tvanderstad tvanderstad deleted the md-polish branch March 16, 2026 21:37
current,
light: ThemeVariant {
black: hex_color!("#101010"),
black: hex_color!("#000000"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvanderstad perhaps the mnemonic tables need to be updated?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, I may have just chosen darker versions of some colors for text only in other themes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wym

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I may have three greens in my Zed theme, with the green used for text in light mode just slightly darker than the green for other foreground things in light mode like icons

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants