Skip to content

apple: fix colors#4218

Merged
Parth merged 2 commits intomasterfrom
fix-theme
Feb 12, 2026
Merged

apple: fix colors#4218
Parth merged 2 commits intomasterfrom
fix-theme

Conversation

@Parth
Copy link
Copy Markdown
Member

@Parth Parth commented Feb 12, 2026

had to do a conceptual diff

the colors are presently from the perspective of a pallete that is foreground centric. While the colors from the editor are background centric.

  • So the editor has defined:
    • neutral 0 - neutral 1:
    • (bg) in dark these are black -> grey
    • (bg) in light these are white -> grey
    • but in (fg) dark we'll use light, which will have white -> grey
    • and in (fg) light we'll use dark, which will have grey -> white

@Parth Parth marked this pull request as ready for review February 12, 2026 22:32
@Parth Parth merged commit dfdcb73 into master Feb 12, 2026
1 check passed
@Parth Parth deleted the fix-theme branch February 12, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant