Skip to content

cli: bear import bugfixes#4171

Merged
Parth merged 7 commits intolockbook:masterfrom
sergigp:fix-bear-import
Feb 3, 2026
Merged

cli: bear import bugfixes#4171
Parth merged 7 commits intolockbook:masterfrom
sergigp:fix-bear-import

Conversation

@sergigp
Copy link
Copy Markdown
Contributor

@sergigp sergigp commented Feb 2, 2026

image
  • skip non markdown files. I made this decision bc import doc points that user needs to export bear notes as markdown.
  • use from_utf8_lossy to replace non utf8 chars
  • improved reporting messages. Just reporting notes imported instead files. User is importing his bear notes, so I guess he doesn't care about lockbook internal implementation (folders, images counted as documents, etc.)

fixes #4118

Copy link
Copy Markdown
Member

@Parth Parth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great, I'll reply to the comment on your issue in a second. Generally we try to indicate what component a PR touches in the title, those end up nicely formatted in our changelog. So this one would ideally be something like cli: bear import bugfixesor something like that.

@Parth
Copy link
Copy Markdown
Member

Parth commented Feb 2, 2026

Additionally, you can stick fixes #issue-number in your PR description, merging this PR will close that issue.

Also I think this is a great first choice for an issue!

@sergigp sergigp changed the title Fix bear import cli: bear import bugfixes Feb 2, 2026
@sergigp sergigp requested a review from Parth February 3, 2026 16:37
paths
}

#[cfg(test)]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Parth
Copy link
Copy Markdown
Member

Parth commented Feb 3, 2026

Congrats on your first contribution!

@Parth Parth merged commit 6466dc2 into lockbook:master Feb 3, 2026
1 check passed
@sergigp sergigp deleted the fix-bear-import branch February 3, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

bear migration problems

2 participants