Conversation
Parth
reviewed
Jan 20, 2026
Parth
requested changes
Jan 20, 2026
Member
|
rebase with care: https://github.com/lockbook/lockbook/pull/4121/files |
Parth
approved these changes
Jan 26, 2026
Member
Parth
left a comment
There was a problem hiding this comment.
everything looks great, some non-blocking nits
libs/lb/lb-rs/src/io/mod.rs
Outdated
Comment on lines
+71
to
+73
| if db.id.get().is_none() { | ||
| db.id.insert(LbID::generate())?; | ||
| } |
Member
There was a problem hiding this comment.
I would add this to whoever calls this function, only reason I say this is because this function is going to be deleted soon and it's possible this will be missed
libs/lb/lb-rs/src/model/account.rs
Outdated
Comment on lines
148
to
153
| @@ -151,10 +152,7 @@ impl Account { | |||
| /// their name to this list. Certainly telemetry in lockbook will always be opt in but the | |||
| /// mechanism of consent may evolve over time. | |||
Member
There was a problem hiding this comment.
Can you stick these up by the const now
Comment on lines
+36
to
+43
| impl DebugInfoDisplay for LbResult<DebugInfo> { | ||
| fn to_string(&self) -> String { | ||
| match self { | ||
| Ok(debug_info) => serde_json::to_string_pretty(debug_info).unwrap_or_default(), | ||
| Err(err) => format!("Error retrieving debug info: {:?}", err), | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I meant just impl DebugInfo but this is fine as well
Comment on lines
+61
to
+69
| async fn lb_id(&self) -> LbResult<LbID> { | ||
| let tx = self.ro_tx().await; | ||
| let db = tx.db(); | ||
|
|
||
| db.id | ||
| .get() | ||
| .copied() | ||
| .ok_or_else(|| LbErr::from(LbErrKind::Unexpected("Couldn't get Lb ID".to_string()))) | ||
| } |
Member
There was a problem hiding this comment.
I think this is the thing that should just generate and set it actually.
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3867