Skip to content

md: persist scroll & cursor#4090

Merged
tvanderstad merged 2 commits intomasterfrom
md-persist-cursor
Jan 12, 2026
Merged

md: persist scroll & cursor#4090
tvanderstad merged 2 commits intomasterfrom
md-persist-cursor

Conversation

@tvanderstad
Copy link
Copy Markdown
Contributor

@tvanderstad tvanderstad commented Jan 9, 2026

fixes #3069

works for the active tab only

@Parth
Copy link
Copy Markdown
Member

Parth commented Jan 9, 2026

Just give this a quick test with multiple windows on macOS

@tvanderstad
Copy link
Copy Markdown
Contributor Author

Just give this a quick test with multiple windows on macOS

It is a little weird because the scroll offset will put you in a different place depending on the window size. With one window that's fine because the size is remembered. With two windows the second one can persist a value that doesn't mean the same thing, then when you close and reopen the app, it opens in a different size and you are scrolled to a seemingly-random place.

Think this is value-add enough to merge?

@Parth
Copy link
Copy Markdown
Member

Parth commented Jan 12, 2026

yeah I was mostly concerned about multiple windows interfering with one another making editing impossible or something like that. sounds like that's not the case

@tvanderstad tvanderstad merged commit 9c8c7d2 into master Jan 12, 2026
1 check passed
@tvanderstad tvanderstad deleted the md-persist-cursor branch January 12, 2026 20:06
@tvanderstad
Copy link
Copy Markdown
Contributor Author

yeah the cursor + scroll position are set on load and saved on change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Remember cursor position

2 participants