Updated id_str from TEXT to STRING - did this because we don't want to tokenize it

I do want to be able to search via ID

Updated build_index to compute deleted
I don't know if this change is totally needed just because this only happens on startup. There are some obscure situations where we call build_index like the CLI, but given the nature of how that gets called it's not needed there either.

I would remove, but I would not mind if you do not remove, could go either way.

Updated build_index to compute deleted
I don't know if this change is totally needed just because this only happens on startup. There are some obscure situations where we call build_index like the CLI, but given the nature of how that gets called it's not needed there either.

I would remove, but I would not mind if you do not remove, could go either way.

Agreed not totally needed - leaning towards leaving it since I would assume build_index removes deleted ids

Updated id_str from TEXT to STRING - did this because we don't want to tokenize it

I do want to be able to search via ID

Using TEXT makes it impossible (?) to remove the term by ID, since delete_term performs an ID lookup and no ID exists as a standalone entry

The old code has this:

        for id in delete {
            let term = Term::from_field_text(id_str, &id.to_string());
            index_writer.delete_term(term);
        }

so does this not delete the whole entry? It just clears out that field?

I think having both id as text & string is prob fine, it's small. But yeah checkout the docs.

so does this not delete the whole entry? It just clears out that field?

It doesn't delete anything since id_str is tokenized and it fails to find it

I see, unfortunate API design, sounds good best of luck