editor: reveal fold buttons on hover#4056
Merged
tvanderstad merged 2 commits intomasterfrom Dec 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hover-reveal-fold-buttons.mov
The code for fold buttons remains untidy as I'm still figuring out how this ought to work. The conditions for revealing the fold button are:
This is what was simplest to implement and I'd like to see how it goes. One shortcoming here is that I haven't worked out the hit-testing i.e. the fold button could still be revealed if the hovered location is behind a modal like settings. To fix this, I should use the hit-testing system, but if I did that the text itself (in a list item) would cover the much of the area where the children nodes are rendered and prevent hovers from registering. I think the target state is for block nodes to return responses indicating hover/click/etc the way inline nodes do, and for headings to use this pattern as well, if I can solve the hit-testing problem.