Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared with me
This re-works our file tree and workspace to uplift pending-shares to first class citizens in lockbook. Presently if I want to start collaborating with someone they have to:
before they can even see what they're accepting.
Now all their shares will just hang out in there, indexed by who shared it, sorted by what what changed the most recently. There is no longer any obligation to accept a share and they can read / write any of the things they have access to.
I also changed the suggested docs icon to ✨ (kinda) and this is what it looks like when shares are collapsed:
#3511 on linux & windows.
Remaining work
in the order that I plan to do it.