Merged
Conversation
tvanderstad
reviewed
Nov 26, 2025
| image = "0.24" | ||
| lb-fonts = { git = "https://github.com/lockbook/lb-fonts" } | ||
| hayro = "0.4.0" | ||
| hayro = "0.3.0" |
Member
Author
There was a problem hiding this comment.
I fixed in a subsequent commit a couple minutes later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ad-tra refined the UI in #3948 which was well received by all.
However due to all the copy and pasting we're doing in the
filetree.rsimplementation, the visual changes didn't apply to suggested docs. If you look in that screenshot it looks like adam's folder is a parent of suggested docs. Suggested docs' icon also doesn't open and close. Also the documents inside suggested docs aren't aligned nicely, and they have extensions when they shouldn't.This PR consolidates the code that draws a file cell so that it can be drawn with a uniform appearance.
I need a reliable visual abstraction for showing file tree like things for #3511
before:
after:
