Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR rebuilds our PDF experience from the ground up, solving some key problems along the way.
Using a pure rust pdf renderer means that some systemic issues caused by lb-pdf go away:
While here I also solved some other problems:
Excitingly this library also paves the way for us to convert pdfs to svgs so we're just a single hacker house with @ad-tra away from having some experience where you can draw on top of PDFs. It'll likely also be possible to implement pdf search (#3365) using this crate, as I believe the crate exposes text parsing functionality (but I'll have to double check to be sure).
The hayro people caution that they haven't done any perf work yet, but a coarse comparison of rendering all the pages resulted in a faster time to first frame than pdfium (although pdfium has to sit through a dl-load syscall which is probably slow, but also for our purposes is part of the comparison).
carfax pdf hayro: 96ms
carfax pdf pdfium: 155ms