Merged
Conversation
Member
Author
|
I'm going to merge this to continue working on the import functionality, but I will be checking for 2 approvals here before I release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on #2078 (the bear part) for @Luca409 and bear normalizes spaces. The export format has links to images with url-encoded-spaces. It looks something like this:
This PR uses a tiny crate which I've already audited (though feel free to explore yourself) to decode these. It falls back on the original string if it reports any failures.
@ad-tra / @tvanderstad the ask is to QA the various image handling flows that use this link resolution logic. I checked a bunch of things but it would be good for you guys to check as well and lmk if there are any failures. Ideally you'll do this in the next couple days, but for sure before the next release.
Please & Thanks.