added NumericIndexStrategy filtering per dimension as a fallback if no filters#951
Merged
added NumericIndexStrategy filtering per dimension as a fallback if no filters#951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is particularly useful for rasters as no distributable filters are applied based on the sfc keys exactly matching the data geometry (tiles). In general, the assumption is that if a query has a filter set on it (ie. SpatialQueryFilter, SpatialTemporalQueryFilter, CQLQueryFilter) applying that particular filter is more applicable, and covers at least the filtering of the individual dimensions of the SFC. However, in the case that no query filter is provided, but the multi-dimensional constraints are given, multi-dimensional range decomposition is not going to be as effective of a filter as filtering the values of each individual dimension for a key - so instead of just accepting extra false positives, we apply an additional NumericIndexStrategy filter.