Conversation
5fa3fda to
6eca986
Compare
blastarr
approved these changes
Nov 28, 2016
Contributor
blastarr
left a comment
There was a problem hiding this comment.
Looks good. Definite improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hadoop input and output formats are an important external interface, and setting "datastore name" in addition to a map<String,String> is clumsy. Instead you should be able to just set the datastore plugin options. Also, datastore "name" and "type" were being used interchangably which adds to confusion. Settled on using "type" everywhere.