Merged
Conversation
…of formatter plugin
| .max( | ||
| minAxis[i] | ||
| + (minCenterDistanceFactor * (rand.nextInt(Integer.MAX_VALUE) % (range[i] / minCenterDistanceFactor))), | ||
| minAxis[i]); |
Contributor
There was a problem hiding this comment.
This looks really bizarre ... is this the correct formatting?
Contributor
|
Reviewed, didn't see anything major, but could you update the docs in "Building -> Tools" to update the skipFormat command that we always copy/paste always? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff is massive and I would highly encourage someone to pull down my branch and take it for a ride locally prior to merging...
Contains fixes for #591. Specifically formatter plugin was brought up to date and templates were updated to Mars format with same values. Formatting now appears to work correctly from command line when not skipped (which by the way, is now done via
-Dformatter.skip=trueinstead of-DskipFormat=true).Contains a massive format of the codebase to put files in this format.
Also normalizes all line endings via dos2unix which was not done correctly with #755