Conversation
… by 8 - padded left-most bits rather than rightmost
Contributor
Author
|
this one is pretty meaningless considering we will prefer hilbert, but when using bits not divisible by 8 (let's say 10 bits would force you to represent it with 2 bytes so the last 6 bits would be 0 rather than the first 6 bits) we were padding 0's on the end rather than the beginning. It makes more sense to pad to the beginning although both seem valid and would work, this behavior is consistent with hilbert SFC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… by 8 - padded left-most bits rather than rightmost