multiple code improvements: squid:S1197, squid:S1118, squid:S2293, squid:CommentedOutCodeLine, squid:S1481, squid:UselessParenthesesCheck#750
Merged
rfecher merged 1 commit intolocationtech:masterfrom May 6, 2016
DevFactory:release/multiple-code-improvements-fix-1
Merged
multiple code improvements: squid:S1197, squid:S1118, squid:S2293, squid:CommentedOutCodeLine, squid:S1481, squid:UselessParenthesesCheck#750rfecher merged 1 commit intolocationtech:masterfrom DevFactory:release/multiple-code-improvements-fix-1
rfecher merged 1 commit intolocationtech:masterfrom
DevFactory:release/multiple-code-improvements-fix-1
Conversation
Contributor
|
thanks @georgekankava! can you sign an eclipse foundation committer license agreement: https://eclipse.org/legal/#CommitterAgreements on the left there is a link to "Sign" but it requires you to create an account. |
Contributor
Author
|
Hello, I've signed, eclipse foundation committer license agreement. |
…id:CommentedOutCodeLine, squid:S1481,squid:UselessParenthesesCheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules
squid:S1197 - Array designators "[]" should be on the type, not the variable.
squid:S1118 - Utility classes should not have public constructors.
squid:S2293 - The diamond operator ("<>") should be used.
squid:CommentedOutCodeLine - Sections of code should not be "commented out".
squid:S1481 - Unused local variables should be removed.
squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1197
https://dev.eclipse.org/sonar/rules/show/squid:S1118
https://dev.eclipse.org/sonar/rules/show/squid:S2293
https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine
https://dev.eclipse.org/sonar/rules/show/squid:S1481
https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck
Please let me know if you have any questions.
George Kankava