Conversation
| 90 | ||
| })); | ||
| } | ||
| // public static void main( |
Contributor
There was a problem hiding this comment.
do we use this anymore? If not, can we just delete it? (if so, we probably have a problem in the first place here, so I'll assume we don't)
Contributor
|
@rwgdrummer @dcy2003 Do you guys want to review this? Its pretty massive and I'd vote for getting it into 0.9.1 sooner than later so we can press forward. I glanced through it and I really think thats all anyone is going to be able to do without setting aside a full day. Let me know. |
Contributor
|
I peaked through it the other day. Nothing stood out, so I'm good with moving forward with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update includes: #331 #416 #435 #546