GEOWAVE-687: tested and fixed issues with export and ingest from avro#702
Merged
GEOWAVE-687: tested and fixed issues with export and ingest from avro#702
Conversation
Contributor
|
Reviewed. Regarding the TODOs, is the intent to hold off on merging this in until @datasedai finishes command line stuff, or merge it now and have him address them? If the latter, I'm good with this PR. |
Contributor
Author
|
I'd be open to opinion on this but would be happy to merge this with 0.9.1 with the TODOs in place but make sure we mark either in the existing issue or close it and create a new issue for addressing this when @datasedai merges his branch in. Basically, I'd say yes to just go ahead and merge with the TODO, but caveat the addressing it as it doesn't have to be something added to the list of things he needs to address before merging - I can address it after he merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.