Issue #659, #658, #660. Allow the index writer to to multiple indice…#676
Merged
Issue #659, #658, #660. Allow the index writer to to multiple indice…#676
Conversation
42a2f30 to
2e9df23
Compare
…. Retain the index/adapter assocation to identify possibile indices to query for a given adapter and to enfore a consistent set of indices to write for a given adapter across multiple ingest runs or WFS-T transactions. Lastly, eliminate the redudant visibility constraint when creating an index writer Issue #659, #658, #660. Allow the index writer to to multiple indices. Retain the index/adapter assocation to identify possibile indices to query for a given adapter and to enfore a consistent set of indices to write for a given adapter across multiple ingest runs or WFS-T transactions. Lastly, eliminate the redudant visibility constraint when creating an index writer. GEOWAVE-669: moved geowavedemoapp to exmaples so that it could use adapter dependencies; demo app works in windows now Issue #659, #658, #660. Allow the index writer to to multiple indices. Retain the index/adapter assocation to identify possibile indices to query for a given adapter and to enfore a consistent set of indices to write for a given adapter across multiple ingest runs or WFS-T transactions. Lastly, eliminate the redudant visibility constraint when creating an index writer Issue #662. Partition based on boundary of polygon GEOWAVE-669: moved geowavedemoapp to exmaples so that it could use adapter dependencies; demo app works in windows now GEOWAVE-673: added index as optional parameter to KDE merged
| } | ||
|
|
||
| public static void addIndex( | ||
| public static void setIndex( |
Contributor
There was a problem hiding this comment.
Why change it to setIndex? It looks like it still calls addIndex under the hood and it looks like you can still have multiple indices? Am I missing something?
Contributor
There was a problem hiding this comment.
Well, I looked a little deeper, it looks while we append an index every time you call setIndex, we just seemingly arbitrarily use the first index to form query options. Some of this was from before this pull request, but maybe something we should clean up?
|
|
||
| public class DataStoreCallbackManager implements | ||
| AutoCloseable | ||
| public class DataStoreCallbackManager |
Contributor
There was a problem hiding this comment.
why the change from autocloseable to now using a flush?
ba29fab to
2b935a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g