Fix issues and add improvements to basic data type adapters#1867
Merged
rfecher merged 2 commits intolocationtech:masterfrom Feb 23, 2022
Merged
Fix issues and add improvements to basic data type adapters#1867rfecher merged 2 commits intolocationtech:masterfrom
rfecher merged 2 commits intolocationtech:masterfrom
Conversation
Contributor
jdgarrett
commented
Feb 23, 2022
- Fix issues with the use of primitive types
- Allow the data ID field to be kept separate from the other fields so that they don't get serialized twice
- Allow the naming of attribute indices
- Allow no field descriptors to be supplied
- Update data ID serialization to use the field writer for the class instead of toString
- Fix stack overflow on SimpleAbstractDataAdapter
- Fix issues with the use of primitive types - Allow the data ID field to be kept separate from the other fields so that they don't get serialized twice - Allow the naming of attribute indices - Allow no field descriptors to be supplied - Update data ID serialization to use the field writer for the class instead of toString - Fix stack overflow on SimpleAbstractDataAdapter Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
rfecher
approved these changes
Feb 23, 2022
rfecher
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.