Update statistic visibility handling to account for binning strategies#1809
Merged
rfecher merged 2 commits intolocationtech:masterfrom May 27, 2021
Merged
Update statistic visibility handling to account for binning strategies#1809rfecher merged 2 commits intolocationtech:masterfrom
rfecher merged 2 commits intolocationtech:masterfrom
Conversation
Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
rfecher
reviewed
May 27, 2021
| } | ||
|
|
||
| @Override | ||
| public void getFieldsUsed(final Set<String> fieldsUsed) { |
Contributor
There was a problem hiding this comment.
minor nit, but wouldn't a more appropriate name be addFieldsUsed ... it just reads like a getter when its really adding in-place
rfecher
approved these changes
May 27, 2021
Contributor
rfecher
left a comment
There was a problem hiding this comment.
I added a comment with a minor nit, but otherwise looks good
Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
rfecher
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.