Refactor adapters and add explicit adapter to index mappings#1807
Merged
rfecher merged 4 commits intolocationtech:masterfrom May 7, 2021
Merged
Refactor adapters and add explicit adapter to index mappings#1807rfecher merged 4 commits intolocationtech:masterfrom
rfecher merged 4 commits intolocationtech:masterfrom
Conversation
3e7777d to
ca70805
Compare
rfecher
requested changes
May 3, 2021
Contributor
rfecher
left a comment
There was a problem hiding this comment.
I think we could use examples of using field descriptors to define a type instead of using FeatureDataAdapter. Just want to make sure we showcase the power of this major refactoring and some of the new capabilities like lat/lon field mapping.
ca1f17a to
8119e11
Compare
8119e11 to
776031c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR that creates an explicit mapping between adapter and index whenever an adapter is added. By doing this, we can use SPI to discover mappings between adapter fields and index fields and reduce a lot of the hard-coded mappings that existed before. Under the previous system, a lot of the mapping logic was handled by
FeatureDataAdapter, which made implementing customDataTypeAdaptersmore complicated than it should have been.