GEOWAVE-1804: spatial binning strategies#1805
Merged
rfecher merged 1 commit intolocationtech:masterfrom Apr 30, 2021
Merged
Conversation
7c51968 to
1c09369
Compare
jdgarrett
requested changes
Apr 28, 2021
Contributor
jdgarrett
left a comment
There was a problem hiding this comment.
Looks good to me, there were just a couple of things that I thought should be addressed.
| @Parameter( | ||
| names = {"--geometry"}, | ||
| converter = ComplexGeometryBinningOptionConverter.class, | ||
| description = "Approach for handling complex geometry (can use one hash based on the centroid or all covering hashes, and if all covering hashes can optionally scale counts by the percent coverage of the hash with the geometry).") |
Contributor
There was a problem hiding this comment.
This description seems a bit confusing to me, maybe all of the options should be listed?
| @@ -0,0 +1,309 @@ | |||
| package org.locationtech.geowave.examples.stats; | |||
Signed-off-by: Rich Fecher <richard.fecher@maxar.com>
1c09369 to
00dee53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rich Fecher richard.fecher@maxar.com