GEOWAVE-1731: update jcommander to v1.78#1732
Merged
rfecher merged 1 commit intolocationtech:masterfrom May 28, 2020
Merged
Conversation
64328e2 to
3254f18
Compare
Signed-off-by: Rich Fecher <rich.fecher@blacklynx.tech>
jdgarrett
approved these changes
May 27, 2020
Contributor
jdgarrett
left a comment
There was a problem hiding this comment.
This looks good to me. At some point I think we will have to go to a custom Console interface so that we aren't tied to JCommander outside of classes that are specifically for CLI commands. I've noticed a lot of places that directly use System.out or System.err when they should really be using the console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated jcommander to v1.78
the major impact this had was no longer using a static instance of JCommander's
Consolewhich touched a lot of places.While in "commands" I cleaned them and ensured that it didn't change the annotated parameters with "final" by adding setters (generally have adopted that as the best practice to avoid cleanup impacting functionality because JCommander uses reflection it will throw exceptions for inaccessible fields if they are final).
Also renamed the few places that I came across that still have "Geowave" when it should be "GeoWave" consistently across the project for class names.