Skip to content

improved flexibility for directory naming#1729

Merged
rfecher merged 1 commit intolocationtech:masterfrom
rfecher:directory-flex
May 20, 2020
Merged

improved flexibility for directory naming#1729
rfecher merged 1 commit intolocationtech:masterfrom
rfecher:directory-flex

Conversation

@rfecher
Copy link
Copy Markdown
Contributor

@rfecher rfecher commented May 19, 2020

needed to add a quick fix on line 152 of FileSystemOperations (one of the deleteAll methods didn't use subdirectory in creating the path).

So.. in addition to that small fix I did a little cleanup:

  1. added format to the "client" so that it didn't need to be redundantly passed all over the place
  2. allowed for directories supplied by the formatter plugin to be null or empty strings in which case it wouldn't add a subdirectory to the path.
  3. allowed for the formatter to also define the directory of metadata (previously hard-coded to "metadata"

@rfecher rfecher requested a review from jdgarrett May 19, 2020 21:37
Signed-off-by: Rich Fecher <rich.fecher@blacklynx.tech>
@rfecher rfecher merged commit 8306f7a into locationtech:master May 20, 2020
@rfecher rfecher deleted the directory-flex branch May 20, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant