minor tweak to make format api more consistent#1726
Merged
rfecher merged 1 commit intolocationtech:masterfrom May 18, 2020
Merged
minor tweak to make format api more consistent#1726rfecher merged 1 commit intolocationtech:masterfrom
rfecher merged 1 commit intolocationtech:masterfrom
Conversation
Signed-off-by: Rich Fecher <rich.fecher@blacklynx.tech>
beb469a to
f44af27
Compare
jdgarrett
approved these changes
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just added "typeName" and "indexName" to one of the data formatter methods where it was missing. The default binary formatter doesn't use type name or index name anywhere but its provided in every other method as just additional contextual info that can be helpful and used by the formatter as needed. The Data Index formatter passes type name to every method and the Index formatter passes index name and type name to every method, again as potentially useful context for the formatter.