Skip to content

a couple minor conveniences for dynamodb#1718

Merged
rfecher merged 1 commit intolocationtech:masterfrom
rfecher:dynamodb-conveniences
May 5, 2020
Merged

a couple minor conveniences for dynamodb#1718
rfecher merged 1 commit intolocationtech:masterfrom
rfecher:dynamodb-conveniences

Conversation

@rfecher
Copy link
Copy Markdown
Contributor

@rfecher rfecher commented May 4, 2020

These are both extremely minor enhancements for using dynamodb. One is just for launching the local instance, to be able to specify port seems like a pretty basic option you would want. And the other is if region name is not null but is an empty string, it won't use endpoint (it just checks for null in the calling code of this Region, but it really shouldn't try to convert empty strings). For example, we configure with spring YAML, and there's no way to unset a property but you can set it to an empty string which seems like it should be sufficient to ignore "region."

@rfecher rfecher requested a review from jdgarrett May 4, 2020 16:50
Signed-off-by: Rich Fecher <rich.fecher@blacklynx.tech>
@rfecher rfecher force-pushed the dynamodb-conveniences branch from c15a211 to e174d16 Compare May 4, 2020 18:04
@rfecher rfecher merged commit 96ce980 into locationtech:master May 5, 2020
@rfecher rfecher deleted the dynamodb-conveniences branch May 5, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants