a couple minor conveniences for dynamodb#1718
Merged
rfecher merged 1 commit intolocationtech:masterfrom May 5, 2020
Merged
Conversation
Signed-off-by: Rich Fecher <rich.fecher@blacklynx.tech>
c15a211 to
e174d16
Compare
jdgarrett
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are both extremely minor enhancements for using dynamodb. One is just for launching the local instance, to be able to specify port seems like a pretty basic option you would want. And the other is if region name is not null but is an empty string, it won't use endpoint (it just checks for null in the calling code of this Region, but it really shouldn't try to convert empty strings). For example, we configure with spring YAML, and there's no way to unset a property but you can set it to an empty string which seems like it should be sufficient to ignore "region."