Allow subsampling on spatial-temporal indices#1685
Merged
jdgarrett merged 4 commits intolocationtech:masterfrom Mar 1, 2020
Merged
Allow subsampling on spatial-temporal indices#1685jdgarrett merged 4 commits intolocationtech:masterfrom
jdgarrett merged 4 commits intolocationtech:masterfrom
Conversation
Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
rfecher
approved these changes
Feb 28, 2020
Contributor
|
one thing I'd say re: this PR is it'd be nice if there was some testing. There are subsampling tests in this section of the ITs: https://github.com/locationtech/geowave/blob/master/test/src/test/java/org/locationtech/geowave/test/services/GeoServerIngestIT.java#L275-L317 I think one very basic step that could help prove this works properly would be to test with both indices as its done now, then remove the spatial index and repeat the tests (ie. the spatial-temporal only). |
87cef32 to
1cf7bdc
Compare
Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
1cf7bdc to
3441f87
Compare
Signed-off-by: Johnathan Garrett <jd@prominentedge.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.