GEOWAVE-1674: flexibility to have newer versions of jcommander in classpath#1675
Merged
jdgarrett merged 1 commit intolocationtech:masterfrom Feb 17, 2020
Merged
GEOWAVE-1674: flexibility to have newer versions of jcommander in classpath#1675jdgarrett merged 1 commit intolocationtech:masterfrom
jdgarrett merged 1 commit intolocationtech:masterfrom
Conversation
…sspath Signed-off-by: Rich Fecher <rich.fecher@blacklynx.tech>
f836122 to
80c91f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JCommander changed the field names from m_field/m_method to field and method. Using reflection with newer versions of jcommander in the classpath throws a runtime exception (and this is in the code path of some fundamental API calls like
GeoWaveStoreFinder.createDataStore()). It seems we can account for both potential field names as a backup to provide a bit more flexibility in this regard.