fixed issue with deleting from custom index#1664
Merged
jdgarrett merged 4 commits intolocationtech:masterfrom Jan 14, 2020
Merged
fixed issue with deleting from custom index#1664jdgarrett merged 4 commits intolocationtech:masterfrom
jdgarrett merged 4 commits intolocationtech:masterfrom
Conversation
jdgarrett
approved these changes
Jan 10, 2020
Contributor
|
It looks good to me, but there are test failures in many of the IT profiles of the build matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a relatively minor issue simply when deleting from a custom index that was originally masked by issue #1655 and the multi-index deletion issues. Added a test for the custom index query and deletion all by itself along with another test for deletion with the custom index, spatial, and spatial-temporal indices. The commented line with the TODO still exists with the multi-index deletion bug, but this resolves simply deletion from the custom index.